hg4j: src/org/tmatesoft/hg/repo/HgWorkingCopyStatusCollector.java comparison

comparison src/org/tmatesoft/hg/repo/HgWorkingCopyStatusCollector.java @ 280:35125450c804

Erroneous and slow status for working copies based on non-tip revision

author	Artem Tikhomirov <tikhomirov.artem@gmail.com>
date	Fri, 02 Sep 2011 13:40:09 +0200
parents	6d1804fe0ed7
children	e51dd9a14b6f

comparison

equal deleted inserted replaced

-:23e3ea855097
+:35125450c804
 	private final HgRepository repo;
 	private final FileIterator repoWalker;
 	private HgDirstate dirstate;
 	private HgStatusCollector baseRevisionCollector;
 	private PathPool pathPool;
-	private ManifestRevision dirstateParentManifest;
 	public HgWorkingCopyStatusCollector(HgRepository hgRepo) {
 		this(hgRepo, new HgInternals(hgRepo).createWorkingDirWalker(null));
 	}
 		}
 		repoWalker.reset();
 		final PathPool pp = getPathPool();
 		while (repoWalker.hasNext()) {
 			repoWalker.next();
-			Path fname = pp.path(repoWalker.name());
+			final Path fname = pp.path(repoWalker.name());
 			File f = repoWalker.file();
 			if (!f.exists()) {
 				// file coming from iterator doesn't exist.
 				if (knownEntries.remove(fname.toString())) {
 					if (getDirstate().checkRemoved(fname) == null) {
 	private void checkLocalStatusAgainstFile(Path fname, File f, HgStatusInspector inspector) {
 		HgDirstate.Record r;
 		if ((r = getDirstate().checkNormal(fname)) != null) {
 			// either clean or modified
-			if (f.lastModified() / 1000 == r.time && r.size == f.length()) {
+			final boolean timestampEqual = getFileModificationTime(f) == r.time, sizeEqual = r.size == f.length();
-				inspector.clean(getPathPool().path(fname));
+			if (timestampEqual && sizeEqual) {
-			} else {
+				inspector.clean(fname);
+			} else if (!sizeEqual && r.size >= 0) {
+				inspector.modified(fname);
+			} else {
+				// size is the same or unknown, and, perhaps, different timestamp
 				// check actual content to avoid false modified files
 				HgDataFile df = repo.getFileNode(fname);
 				if (!areTheSame(f, df, HgRepository.TIP)) {
 					inspector.modified(df.getPath());
 				} else {
 					inspector.clean(df.getPath());
 				}
 			}
 		} else if ((r = getDirstate().checkAdded(fname)) != null) {
 			if (r.name2 == null) {
-				inspector.added(getPathPool().path(fname));
+				inspector.added(fname);
 			} else {
-				inspector.copied(getPathPool().path(r.name2), getPathPool().path(fname));
+				inspector.copied(getPathPool().path(r.name2), fname);
 			}
 		} else if ((r = getDirstate().checkRemoved(fname)) != null) {
-			inspector.removed(getPathPool().path(fname));
+			inspector.removed(fname);
 		} else if ((r = getDirstate().checkMerged(fname)) != null) {
-			inspector.modified(getPathPool().path(fname));
+			inspector.modified(fname);
 		}
+	}
+	// return mtime analog, directly comparable to dirstate's mtime.
+	private static int getFileModificationTime(File f) {
+		return (int) (f.lastModified() / 1000);
 	}
 	// XXX refactor checkLocalStatus methods in more OO way
 	private void checkLocalStatusAgainstBaseRevision(Set<String> baseRevNames, ManifestRevision collect, int baseRevision, Path fname, File f, HgStatusInspector inspector) {
 		// fname is in the dirstate, either Normal, Added, Removed or Merged
 				return;
 			}
 			inspector.added(fname);
 		} else {
 			// was known; check whether clean or modified
-			// when added - seems to be the case of a file added once again, hence need to check if content is different
+			if ((r = getDirstate().checkNormal(fname)) != null) {
-			if ((r = getDirstate().checkNormal(fname)) != null || (r = getDirstate().checkMerged(fname)) != null || (r = getDirstate().checkAdded(fname)) != null) {
+				final boolean timestampEqual = getFileModificationTime(f) == r.time, sizeEqual = r.size == f.length();
+				if (timestampEqual && sizeEqual) {
+					inspector.clean(fname);
+					baseRevNames.remove(fname.toString()); // consumed, processed, handled.
+					return;
+				} else if (!sizeEqual && r.size >= 0) {
+					inspector.modified(fname);
+					baseRevNames.remove(fname.toString()); // consumed, processed, handled.
+					return;
+				}
+				// otherwise, shall check actual content (size not the same, or unknown (-1 or -2), or timestamp is different)
+				// FALL THROUGH
+			}
+			if (r != null /*Normal dirstate, but needs extra check*/ || (r = getDirstate().checkMerged(fname)) != null || (r = getDirstate().checkAdded(fname)) != null) {
+				// when added - seems to be the case of a file added once again, hence need to check if content is different
 				// either clean or modified
-				HgDataFile fileNode = repo.getFileNode(fname);
+				if (r.size != -1 /*XXX what about ==-2?*/&& r.size != f.length() || !todoCheckFlagsEqual(f, flags)) {
-				int lengthAtRevision;
-				try {
-					lengthAtRevision = fileNode.length(nid1);
-				} catch (HgDataStreamException ex) {
-					ex.printStackTrace(); // XXX log error
-					lengthAtRevision = -1; // compare file content then
-				}
-				// XXX is it safe with respect to filters (keyword, eol) to compare lengthAtRevision (unprocessed) with size
-				// from dirstate, which I assume is size of processed data?
-				if (r.size != -1 && r.size /* XXX File.length() ?! */ != lengthAtRevision || flags != todoGenerateFlags(fname /*java.io.File*/)) {
 					inspector.modified(fname);
 				} else {
 					// check actual content to see actual changes
+					HgDataFile fileNode = repo.getFileNode(fname);
 					if (areTheSame(f, fileNode, fileNode.getLocalRevision(nid1))) {
 						inspector.clean(fname);
 					} else {
 						inspector.modified(fname);
 					}
 			ex.printStackTrace();
 		}
 		return false;
 	}
-	private static String todoGenerateFlags(Path fname) {
+	private static boolean todoCheckFlagsEqual(File f, String manifestFlags) {
 		// FIXME implement
-		return null;
+		return true;
 	}
 	/**
 	 * Configure status collector to consider only subset of a working copy tree. Tries to be as effective as possible, and to
 	 * traverse only relevant part of working copy on the filesystem.

Mercurial > hg4j

comparison src/org/tmatesoft/hg/repo/HgWorkingCopyStatusCollector.java @ 280:35125450c804