diff src/org/tmatesoft/hg/core/HgManifestCommand.java @ 142:37a34044e6bd

More reasonable use of path normalizer and path.source
author Artem Tikhomirov <tikhomirov.artem@gmail.com>
date Thu, 17 Feb 2011 05:06:07 +0100
parents 4a948ec83980
children b9700740553a
line wrap: on
line diff
--- a/src/org/tmatesoft/hg/core/HgManifestCommand.java	Thu Feb 17 04:08:34 2011 +0100
+++ b/src/org/tmatesoft/hg/core/HgManifestCommand.java	Thu Feb 17 05:06:07 2011 +0100
@@ -28,6 +28,7 @@
 import org.tmatesoft.hg.repo.HgRepository;
 import org.tmatesoft.hg.util.Path;
 import org.tmatesoft.hg.util.PathPool;
+import org.tmatesoft.hg.util.PathRewrite;
 
 
 /**
@@ -106,12 +107,16 @@
 
 	// I'd rather let HgManifestCommand implement HgManifest.Inspector directly, but this pollutes API alot
 	private class Mediator implements HgManifest.Inspector {
+		// file names are likely to repeat in each revision, hence caching of Paths.
+		// However, once HgManifest.Inspector switches to Path objects, perhaps global Path pool
+		// might be more effective?
 		private PathPool pathPool;
 		private List<FileRevision> manifestContent;
 		private Nodeid manifestNodeid;
 		
 		public void start() {
-			pathPool = new PathPool(repo.getPathHelper());
+			// Manifest keeps normalized paths
+			pathPool = new PathPool(new PathRewrite.Empty());
 		}
 		
 		public void done() {