# HG changeset patch # User Artem Tikhomirov # Date 1329141141 -3600 # Node ID 73e875154afb2be433e114e003ae41e490764bfd # Parent 6150555eb41dababa36605a41fe2419157584bab Do not fail with empty extras string in changeset diff -r 6150555eb41d -r 73e875154afb src/org/tmatesoft/hg/repo/HgChangelog.java --- a/src/org/tmatesoft/hg/repo/HgChangelog.java Mon Feb 13 14:19:36 2012 +0100 +++ b/src/org/tmatesoft/hg/repo/HgChangelog.java Mon Feb 13 14:52:21 2012 +0100 @@ -284,7 +284,7 @@ String _extras = space2 < _timeString.length() ? _timeString.substring(space2 + 1) : null; Map _extrasMap; final String extras_branch_key = "branch"; - if (_extras == null) { + if (_extras == null || _extras.trim().length() == 0) { _extrasMap = Collections.singletonMap(extras_branch_key, HgRepository.DEFAULT_BRANCH_NAME); } else { _extrasMap = new HashMap(); diff -r 6150555eb41d -r 73e875154afb test/org/tmatesoft/hg/tools/ChangelogEntryBuilder.java --- a/test/org/tmatesoft/hg/tools/ChangelogEntryBuilder.java Mon Feb 13 14:19:36 2012 +0100 +++ b/test/org/tmatesoft/hg/tools/ChangelogEntryBuilder.java Mon Feb 13 14:52:21 2012 +0100 @@ -67,7 +67,7 @@ } public ChangelogEntryBuilder branch(String branchName) { - if (branchName == null) { + if (branchName == null || "default".equals(branchName)) { extrasMap.remove("branch"); } else { extrasMap.put("branch", branchName); @@ -114,15 +114,17 @@ } } StringBuilder files = new StringBuilder(); - for (Iterator it = modifiedFiles.iterator(); it.hasNext(); ) { - files.append(it.next()); - if (it.hasNext()) { - files.append('\n'); + if (modifiedFiles != null) { + for (Iterator it = modifiedFiles.iterator(); it.hasNext(); ) { + files.append(it.next()); + if (it.hasNext()) { + files.append('\n'); + } } } final long date = csetTime(); final int tz = csetTimezone(date); - return String.format(f, manifestRevision.toString(), user, date, tz, extras, files, comment).getBytes(); + return String.format(f, manifestRevision.toString(), user(), date, tz, extras, files, comment).getBytes(); } private final static CharSequence encodeExtrasPair(String s) {