# HG changeset patch # User Artem Tikhomirov # Date 1316260848 -7200 # Node ID 88c58edc08575ba365773a42d790dfad170434e6 # Parent 650b45d290b1bd72ec4b94070a2962628b9379fc Remarks about sorting order diff -r 650b45d290b1 -r 88c58edc0857 src/org/tmatesoft/hg/core/Nodeid.java --- a/src/org/tmatesoft/hg/core/Nodeid.java Sat Sep 17 13:41:04 2011 +0200 +++ b/src/org/tmatesoft/hg/core/Nodeid.java Sat Sep 17 14:00:48 2011 +0200 @@ -92,6 +92,9 @@ } for (int i = 0; i < 20; i++) { if (binaryData[i] != o.binaryData[i]) { + // if we need truly ascending sort, need to respect byte sign + // return (binaryData[i] & 0xFF) < (o.binaryData[i] & 0xFF) ? -1 : 1; + // however, for our purposes partial sort is pretty enough return binaryData[i] < o.binaryData[i] ? -1 : 1; } }