Mercurial > hg4j

changeset 597:c895b5556937

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Wrap manifest revision map completion into single file access
author Artem Tikhomirov <tikhomirov.artem@gmail.com>
date Fri, 03 May 2013 14:10:40 +0200
parents 43cfa08ff3fd
children d29d9dc6c128
files src/org/tmatesoft/hg/repo/HgManifest.java
diffstat 1 files changed, 24 insertions(+), 11 deletions(-) [+]
line wrap: on
line diff
--- a/src/org/tmatesoft/hg/repo/HgManifest.java	Thu May 02 19:23:53 2013 +0200
+++ b/src/org/tmatesoft/hg/repo/HgManifest.java	Fri May 03 14:10:40 2013 +0200
@@ -21,7 +21,6 @@
 import static org.tmatesoft.hg.util.LogFacility.Severity.Info;
 
 import java.io.IOException;
-import java.util.ArrayList;
 import java.util.Arrays;
 
 import org.tmatesoft.hg.core.HgChangesetFileSneaker;
@@ -33,9 +32,11 @@
 import org.tmatesoft.hg.internal.EncodingHelper;
 import org.tmatesoft.hg.internal.IdentityPool;
 import org.tmatesoft.hg.internal.IntMap;
+import org.tmatesoft.hg.internal.IntVector;
 import org.tmatesoft.hg.internal.IterateControlMediator;
 import org.tmatesoft.hg.internal.Lifecycle;
 import org.tmatesoft.hg.internal.RevlogStream;
+import org.tmatesoft.hg.repo.HgChangelog.RawChangeset;
 import org.tmatesoft.hg.util.CancelSupport;
 import org.tmatesoft.hg.util.LogFacility.Severity;
 import org.tmatesoft.hg.util.Path;
@@ -637,21 +638,33 @@
 				return;
 			}
 			// I assume there'd be not too many revisions we don't know manifest of
-			ArrayList<Integer> undefinedChangelogRevision = new ArrayList<Integer>();
+			IntVector undefinedChangelogRevision = new IntVector();
 			for (int i = 0; i < changelog2manifest.length; i++) {
 				if (changelog2manifest[i] == BAD_REVISION) {
 					undefinedChangelogRevision.add(i);
 				}
 			}
-			for (int u : undefinedChangelogRevision) {
-				Nodeid manifest = repo.getChangelog().range(u, u).get(0).manifest();
-				// TODO calculate those missing effectively (e.g. cache and sort nodeids to speed lookup
-				// right away in the #next (may refactor ParentWalker's sequential and sorted into dedicated helper and reuse here)
-				if (manifest.isNull()) {
-					repo.getSessionContext().getLog().dump(getClass(), Severity.Warn, "Changeset %d has no associated manifest entry", u);
-					// keep -1 in the changelog2manifest map.
-				} else {
-					changelog2manifest[u] = repo.getManifest().getRevisionIndex(manifest);
+			if (undefinedChangelogRevision.size() > 0) {
+				final IntMap<Nodeid> missingCsetToManifest = new IntMap<Nodeid>(undefinedChangelogRevision.size());
+				int[] undefinedClogRevs = undefinedChangelogRevision.toArray();
+				// undefinedChangelogRevision is sorted by the nature it's created
+				repo.getChangelog().rangeInternal(new HgChangelog.Inspector() {
+					
+					public void next(int revisionIndex, Nodeid nodeid, RawChangeset cset) {
+						missingCsetToManifest.put(revisionIndex, cset.manifest());
+					}
+				}, undefinedClogRevs);
+				assert missingCsetToManifest.size() == undefinedChangelogRevision.size();
+				for (int u : undefinedClogRevs) {
+					Nodeid manifest = missingCsetToManifest.get(u);
+					// TODO calculate those missing effectively (e.g. cache and sort nodeids to speed lookup
+					// right away in the #next (may refactor ParentWalker's sequential and sorted into dedicated helper and reuse here)
+					if (manifest == null || manifest.isNull()) {
+						repo.getSessionContext().getLog().dump(getClass(), Severity.Warn, "Changeset %d has no associated manifest entry", u);
+						// keep -1 in the changelog2manifest map.
+					} else {
+						changelog2manifest[u] = repo.getManifest().getRevisionIndex(manifest);
+					}
 				}
 			}
 		}