jhg: src/org/tmatesoft/hg/repo/HgDirstate.java comparison

comparison src/org/tmatesoft/hg/repo/HgDirstate.java @ 348:a0864b2892cd

Expose errors reading mercurial control files with exception

author	Artem Tikhomirov <tikhomirov.artem@gmail.com>
date	Thu, 24 Nov 2011 02:57:03 +0100
parents	72c6eda838a6
children	aa2e589d4e84

comparison

equal deleted inserted replaced

-:8da7ade36c57
+:a0864b2892cd
 import static org.tmatesoft.hg.core.Nodeid.NULL;
 import java.io.BufferedReader;
 import java.io.File;
+import java.io.FileNotFoundException;
 import java.io.FileReader;
 import java.io.IOException;
 import java.util.Collections;
 import java.util.HashMap;
 import java.util.LinkedHashMap;
 import java.util.Map;
 import java.util.TreeSet;
-import org.tmatesoft.hg.core.HgBadStateException;
+import org.tmatesoft.hg.core.HgInvalidControlFileException;
 import org.tmatesoft.hg.core.Nodeid;
 import org.tmatesoft.hg.internal.DataAccess;
 import org.tmatesoft.hg.util.Pair;
 import org.tmatesoft.hg.util.Path;
 import org.tmatesoft.hg.util.PathPool;
 		dirstateFile = dirstate; // XXX decide whether file names shall be kept local to reader (see #branches()) or passed from outside
 		this.pathPool = pathPool;
 		canonicalPathRewrite = canonicalPath;
 	}
-	private void read() {
+	/*package-local*/ void read() throws HgInvalidControlFileException {
 		normal = added = removed = merged = Collections.<Path, Record>emptyMap();
 		if (canonicalPathRewrite != null) {
 			canonical2dirstateName = new HashMap<Path,Path>();
 		} else {
 			canonical2dirstateName = Collections.emptyMap();
 				} else {
 					// FIXME log error?
 				}
 			}
 		} catch (IOException ex) {
-			repo.getContext().getLog().error(getClass(), ex, null);
+			throw new HgInvalidControlFileException("Dirstate read failed", ex, dirstateFile);
-			// FIXME clean dirstate?
 		} finally {
 			da.done();
 		}
 	}
 	/**
 	 * @return pair of working copy parents, with {@link Nodeid#NULL} for missing values.
 	 */
 	public Pair<Nodeid,Nodeid> parents() {
-		if (parents == null) {
+		assert parents != null; // instance not initialized with #read()
-			parents = readParents(repo, dirstateFile);
-		}
 		return parents;
 	}
 	/**
 	 * @return pair of parents, both {@link Nodeid#NULL} if dirstate is not available
 	 */
-	/*package-local*/ static Pair<Nodeid, Nodeid> readParents(HgRepository repo, File dirstateFile) {
+	/*package-local*/ static Pair<Nodeid, Nodeid> readParents(HgRepository repo, File dirstateFile) throws HgInvalidControlFileException {
 		// do not read whole dirstate if all we need is WC parent information
 		if (dirstateFile == null || !dirstateFile.exists()) {
 			return new Pair<Nodeid,Nodeid>(NULL, NULL);
 		}
 		DataAccess da = repo.getDataAccess().create(dirstateFile);
 			return new Pair<Nodeid,Nodeid>(NULL, NULL);
 		}
 		try {
 			return internalReadParents(da);
 		} catch (IOException ex) {
-			throw new HgBadStateException(ex); // XXX in fact, our exception is not the best solution here.
+			throw new HgInvalidControlFileException("Error reading working copy parents from dirstate", ex, dirstateFile);
 		} finally {
 			da.done();
 		}
 	}
 	/**
+	 * FIXME move to a better place, e.g. WorkingCopy container that tracks both dirstate and branches (and, perhaps, undo, lastcommit and other similar information)
 	 * @return branch associated with the working directory
 	 */
-	public String branch() {
+	public String branch() throws HgInvalidControlFileException {
 		// XXX is it really proper place for the method?
 		if (currentBranch == null) {
 			currentBranch = readBranch(repo);
 		}
 		return currentBranch;
 	/**
 	 * XXX is it really proper place for the method?
 	 * @return branch associated with the working directory
 	 */
-	/*package-local*/ static String readBranch(HgRepository repo) {
+	/*package-local*/ static String readBranch(HgRepository repo) throws HgInvalidControlFileException {
 		String branch = HgRepository.DEFAULT_BRANCH_NAME;
 		File branchFile = new File(repo.getRepositoryRoot(), "branch");
 		if (branchFile.exists()) {
 			try {
 				BufferedReader r = new BufferedReader(new FileReader(branchFile));
 				if (b != null) {
 					b = b.trim().intern();
 				}
 				branch = b == null || b.length() == 0 ? HgRepository.DEFAULT_BRANCH_NAME : b;
 				r.close();
+			} catch (FileNotFoundException ex) {
+				repo.getContext().getLog().debug(HgDirstate.class, ex, null); // log verbose debug, exception might be legal here
+				// IGNORE
 			} catch (IOException ex) {
-				repo.getContext().getLog().debug(HgDirstate.class, ex, null); // log verbose debug, exception might be legal here (i.e. FileNotFound)
+				throw new HgInvalidControlFileException("Error reading file with branch information", ex, branchFile);
-				// IGNORE
 			}
 		}
 		return branch;
 	}
 	// new, modifiable collection
 	/*package-local*/ TreeSet<Path> all() {
-		if (normal == null) {
+		assert normal != null;
-			read();
-		}
 		TreeSet<Path> rv = new TreeSet<Path>();
 		@SuppressWarnings("unchecked")
 		Map<Path, Record>[] all = new Map[] { normal, added, removed, merged };
 		for (int i = 0; i < all.length; i++) {
 			for (Record r : all[i].values()) {
 			}
 		}
 		return null;
 	}
-	/*package-local*/ void dump() {
-		read();
-		@SuppressWarnings("unchecked")
-		Map<Path, Record>[] all = new Map[] { normal, added, removed, merged };
-		char[] x = new char[] {'n', 'a', 'r', 'm' };
-		for (int i = 0; i < all.length; i++) {
-			for (Record r : all[i].values()) {
-				System.out.printf("%c %3o%6d %30tc\t\t%s", x[i], r.mode, r.size, (long) r.time * 1000, r.name1);
-				if (r.name2 != null) {
-					System.out.printf(" --> %s", r.name2);
-				}
-				System.out.println();
-			}
-			System.out.println();
-		}
-	}
 	public void walk(Inspector inspector) {
-		if (normal == null) {
+		assert normal != null;
-			read();
-		}
 		@SuppressWarnings("unchecked")
 		Map<Path, Record>[] all = new Map[] { normal, added, removed, merged };
 		for (int i = 0; i < all.length; i++) {
 			EntryKind k = EntryKind.values()[i];
 			for (Record r : all[i].values()) {
 		public int size() {
 			return size;
 		}
+		public int mode() {
+			return mode;
+		}
 		@Override
 		public Record clone()  {
 			try {
 				return (Record) super.clone();
 			} catch (CloneNotSupportedException ex) {

Mercurial > jhg

comparison src/org/tmatesoft/hg/repo/HgDirstate.java @ 348:a0864b2892cd